search

emberstack / docker-sftp

SFTP Server for Docker
MIT License
196 stars 51 forks source link

Setting primary GID for users to be created from config. #89

Closed MrDonkey07 closed 1 year ago

MrDonkey07 commented 2 years ago

Setting primary GID for users to be created from config.

Rather than creating default individual groups for each user when calling useradd, the specified GID for that user will be used as the user's primary group. This ensures that files created by that user inside the container are correctly owned by the specified host GID.

winromulus commented 2 years ago

I'm going to keep this open for a bit because:

  1. I don't have a stable dev environment right now
  2. The pipeline is dependent on some secrets and need to refactor that one first
  3. This requires QUITE a bit of testing before being merged

I'm hoping to tackle this during this holiday season when I have more free time.

fliot commented 2 years ago

I faced the GID:1001 hardcoded issue, I just reused the MrDonkey07 branch, and I herbly confirm it solved the issue. Thanks ! If I may, I vote for merge request approval.

stale[bot] commented 2 years ago

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

Automatically closed stale item.

FingerlessGlov3s commented 2 years ago

Also hitting the default 1001 bug.

torsteinelv commented 1 year ago

update?

stale[bot] commented 1 year ago

Removed stale label.