embiem / react-canvas-draw

React Component for drawing in canvas
https://embiem.github.io/react-canvas-draw/
MIT License
904 stars 315 forks source link

Add codecov and coveralls as devDeps #32

Closed tooolbox closed 4 years ago

tooolbox commented 5 years ago

Your package.json on GitHub does not include Codecov and Coveralls.

However, because your .travis.yml includes commands to install both of these packages, when Travis publishes to NPM you have Codecov and Coveralls in the deps.

This is silly because then pulling in react-canvas-draw into a project will pull in these packages which are really only needed for development and CI.

This PR explicitly adds Codecov and Coveralls to your devDeps so that Travis won't sneak them into your regular deps!

embiem commented 4 years ago

Thanks a lot!