search

embiem / react-canvas-draw

React Component for drawing in canvas
https://embiem.github.io/react-canvas-draw/
MIT License
902 stars 315 forks source link

LoadSavedData - Treat as a transaction #93

Open ish-joshi opened 4 years ago

ish-joshi commented 4 years ago

Realtime support

I was attempting to build a real time drawing board using Firebase database when I realised something very strange.

I am using the onChange handler to be notified of any updates so that they can be written to the database.

Once new data is received, it is passed to the component to be re-drawn. As it redraws each line, the onChange is triggered for each line, which causes an infinite loop.

What do the creators/maintainers think about treating the whole loadSaveData() as a transaction; after all lines are drawn the change notification is published. I already have made changes to the existing library and tested to make sure it works.

Check out this fork (https://github.com/ish-joshi/react-canvas-draw) and I'm happy to raise a PR if maintainers/contributors agree with the approach.

HenryLeC commented 3 years ago

I am doing the same thing in my app, and I just dont update the database while loadSaveData is running

embiem commented 3 years ago

Seems like a bug to me tbh. If you'd still be interested to create a PR, then please do so.

Otherwise I'll pull the changes from your fork.

Thanks for reporting this!