embl-cba / fly-reg

BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Class msiing #8

Closed ssgpers closed 3 years ago

ssgpers commented 3 years ago

@tischi

Class which we used in drosophila screen project does not exist anymore:

image

Do I need to update the code or will you reintroduce this class?

tischi commented 3 years ago

It looks like it has been renamed to FlyEmbryoNerveCordRegistration:

image
ssgpers commented 3 years ago

I exchanged the class name, now it complains that class needs to be parametrised.

image

Before it was somehow working, just giving warning, now I have an error:

You can clone embryo screen project and test. These are my classes affected: https://git.embl.de/grp-almf/feedback-fly-embryo-crocker/-/blob/master/src/main/java/feedback/fly/embryo/jobs/Job_FocusEmbryoAutoDatasetSplit.java https://git.embl.de/grp-almf/feedback-fly-embryo-crocker/-/blob/master/src/test/java/algorithm/tests/FindEmbryoOrientationTischi.java

tischi commented 3 years ago

You have declare the type indeed. You could declare it at the level of the calling class or function. For example:

public static < T extends RealType< T > & NativeType< T > > void register()
{
    final FlyEmbryoNerveCordRegistration< T > registration = new FlyEmbryoNerveCordRegistration<>( settings, opService );

    registration.run( ... );
}

Probably there is another way of doing this on my side, but that should be the quickest solution.

ssgpers commented 3 years ago

Works now, thanks. Needed to make the method static in order not to parametrize entire class.