Bookmarks ui

[K-Meech]

Changes for bookmark ui

Main changes:

• refactored some of the table code for selecting files to generic functions (so can be re-used for both tables and bookmarks)
• added getters for properties needed by bookmarks
• expanded github file commit to accept branch and file sha (needed to update an existing file)
• added support for saving colours in format "(r=255,g=255,b=255,a=255)", this allows us to save / load any colour set from the gui. It also fixes a current bug where changing an image colour then removing it / re-adding it makes it appear white.

[K-Meech]

Thanks!! All looks good to me - I'll make those changes!

[K-Meech]

Ok - I've made all the changes (apart from switching to using enum - it's a bit difficult with how the generic dialogs are populated..) For the ARGBLut, I ended up adding getName() and also setName(). The setName() is needed as we have to account for when the transparency checkbox is ticked (and change the name accordingly).

I also had to add a special case for the A-R-G-B colour scheme, as here the ARGBLut is actually null.

[tischi]

it's a bit difficult with how the generic dialogs are populated

Yes, I know. So it's fine to not do it now.

and also setName(). The setName() is needed as we have to account for when the transparency checkbox is ticked (and change the name accordingly).

Not sure that's the best solution. If that's something generic to all ARGBLuts that maybe rather add a

setTransparency method, which would adapt the name in a consistent way?

Anyway, I'll merge now (maybe you could make an issue for the setTransparency and think about it later.

[K-Meech]

Sweet! I'll make an issue. Shall I upload it to MoBIEBeta so people can try it out?

[tischi]

Shall I upload it to MoBIEBeta so people can try it out?

Yes 🚀