search

embl-cba / imagej-utils

BSD 2-Clause "Simplified" License
2 stars 4 forks source link

Determine s3 credentials dynamically and add CustomXmlIoSpimData #46

Closed constantinpape closed 3 years ago

constantinpape commented 3 years ago

I think I figured out how to determine if a bucket needs credentials dynamically, see these changes. This means we could get rid of S3CredentialsCreator and the Authentication parameter as well as the corresponding field in the bdv.xml. I still need to fully test this, because there is an unrelated issue with accessing private buckets, see https://github.com/mobie/mobie-viewer-fiji/issues/182#issuecomment-798114598.

@tischi What do you think, should we go for this change? (If it indeed works)

constantinpape commented 3 years ago

I added CustomXmlIoSpimData that supports loading the xml file from a file stream, so that xml files from s3 (or other resources) can be passed. (And it works).

constantinpape commented 3 years ago

@tischi this is good to be merged from my side.

constantinpape commented 3 years ago

Sorry, I wasn't quite down with this after all; I also removed the "S3CredentialsCreator", which is not necessary any more now that the type of credentials is inferred dynamically. I still need to check that this works with the mobie-viewer.

constantinpape commented 3 years ago

All working now, see also https://github.com/mobie/mobie-viewer-fiji/pull/215