embl-cba / plateviewer

4 stars 2 forks source link

Error when starting the plateViewer #28

Closed constantinpape closed 4 years ago

constantinpape commented 4 years ago

I get the following error when I try to open the plate viewer with one of the folders processed by batchlib. I am using the latest version in Fiji.

Screenshot from 2020-05-10 20-46-07

tischi commented 4 years ago
  1. Which plate was it?
  2. If you uncheck the well and image table loading, does it still happen?
constantinpape commented 4 years ago
  • Which plate was it?

This was just for the small test sample I get for this data: https://github.com/hci-unihd/batchlib/tree/master/data/test_data/test

  • If you uncheck the well and image table loading, does it still happen?

It only happens for the well table (loading not table works and also loading just the image table works).

Maybe it's due to the changes I made to the table columns yesterday. If so, you can check if it works for any of these plates: /g/kreshuk/data/covid/sandbox/for_tischi

They have been written with the latest version. I don't have time to check them right now, I can do it later.

tischi commented 4 years ago

For me it works => some nasty multi-threading issues. I released a new version, hopefully more thread-safe...

constantinpape commented 4 years ago

Ok, I will test it later

constantinpape commented 4 years ago

Still the same issue. I will zip the folder later and upload it somewhere. Also, @wolny mentioned he saw something similar.

constantinpape commented 4 years ago

Ok, nvmd @wolny's issue is only related to the issue reporting.

constantinpape commented 4 years ago

https://oc.embl.de/index.php/s/PGZRHc8dGSVrQZs

tischi commented 4 years ago

Thanks for reporting and providing the example. My scatter plot code was crashing if there is only one data point, which was the case for the wells in this example.

I simply capture this now, because having a scatter plot for only one data point seems not to be too useful anyway...

fetchDataPoints( columnNameX, columnNameY );

if ( points.size() < 2 )
{
    throw new UnsupportedOperationException( "Cannot create scatter plot \"" + name + "\", because there are less than two valid data points." );
}