search

embodied-computation-group / systole

Systole: A python package for cardiac signal synchrony and analysis
https://embodied-computation-group.github.io/systole/#
GNU General Public License v3.0
81 stars 31 forks source link

Change numpy version requirement #62

Closed kclapper closed 1 year ago

kclapper commented 1 year ago

Hello!

I was helping someone with a Python script they wrote using Systole. They kept running into dependency conflicts while trying to use the following packages:

Some combination of these had Numpy dependencies during build and runtime that couldn't be resolved by pip. By removing the <=1.23 constraint on Numpy in the requirements.txt file, this issue was resolved.

All of the Systole tests pass using Numpy version 1.24.4. I'm running Python version 3.10.4.

This is a small change so I just submitted a PR, but I'd be happy to open an Issue too if you'd like.

LegrandNico commented 1 year ago

Sorry for being late on this one, this is merged! Thank you for pointing this out.