embotech / ecos

A lightweight conic solver for second-order cone programming.
GNU General Public License v3.0
478 stars 123 forks source link

Redundant unset_equilibration in ECOS_updateData() #183

Closed EmbersArc closed 4 years ago

EmbersArc commented 4 years ago

It looks like this call to unset_eqilibration() is redundant since the matrices and vectors that get restored by it are overwritten right after. This would not be an issue by itself, but is very inconvenient since it forces the user to alternate between two locations in memory for the A, G, c, h, b data between calls to ECOS_updateData() and ECOS_solve().

https://github.com/embotech/ecos/blob/d0a0551827a3f7b01dee261604ef02c5706d8c15/src/ecos.c#L1655