search

embotech / ecos

A lightweight conic solver for second-order cone programming.
GNU General Public License v3.0
479 stars 123 forks source link

Move GNUInstallDirs include #189

Open EmbersArc opened 4 years ago

EmbersArc commented 4 years ago

I noticed an issue with the CMake installation: The line to import the include directory was in the wrong place which lead to the important preprocessor definitions LDL_LONG and DLONG not being included correctly . I tested this change on Linux.

This change is Reviewable

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling baf3af6f3325a331baf895f34296a4df1fdd6af1 on EmbersArc:cmake_fix into 3d2f48bf788cf8445ea0c38fe767a10d4166e708 on embotech:develop.

csorvagep commented 3 years ago

I noticed this as well, but because this resulted to an invalid include directory of /usr/local//ecos instead of /usr/local/include/ecos.

I did the same modification, although I'm not sure, of the right location. Maybe this fits better between the set() directives and the add_library(). But I'm only splitting hairs, please accept this PR.