search

embrace-io / embrace-android-sdk

Embrace's Android SDK built on OpenTelemetry
https://embrace.io/docs/android/
Apache License 2.0
135 stars 11 forks source link

Ensure logs are persisted sync in case of crash #1298

Closed fractalwrench closed 2 months ago

fractalwrench commented 2 months ago

Goal

Ensures that logs are persisted synchronously if a crash happens.

Testing

Added unit tests.

github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.21%. Comparing base (8577812) to head (f9c059e). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298/graphs/tree.svg?width=650&height=150&src=pr&token=4kNC8ceoVB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## master #1298 +/- ## ========================================== - Coverage 83.22% 83.21% -0.01% ========================================== Files 481 481 Lines 11259 11263 +4 Branches 1718 1719 +1 ========================================== + Hits 9370 9373 +3 Misses 1148 1148 - Partials 741 742 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [...dk/internal/comms/delivery/DeliveryCacheManager.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FDeliveryCacheManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0RlbGl2ZXJ5Q2FjaGVNYW5hZ2VyLmt0) | `100.00% <100.00%> (ø)` | | | [...rnal/comms/delivery/EmbraceDeliveryCacheManager.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FEmbraceDeliveryCacheManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0VtYnJhY2VEZWxpdmVyeUNhY2hlTWFuYWdlci5rdA==) | `84.21% <100.00%> (+0.51%)` | :arrow_up: | | [...nal/comms/delivery/EmbracePendingApiCallsSender.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FEmbracePendingApiCallsSender.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0VtYnJhY2VQZW5kaW5nQXBpQ2FsbHNTZW5kZXIua3Q=) | `74.44% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1298/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)