search

embrace-io / embrace-android-sdk

Embrace's Android SDK built on OpenTelemetry
https://embrace.io/docs/android/
Apache License 2.0
135 stars 11 forks source link

Tweak ndk service code #1299

Closed fractalwrench closed 1 month ago

fractalwrench commented 2 months ago

Goal

Improves the NDK service code by removing a few unused functions & simplifying constructs.

Testing

Relied on existing test coverage.

github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 87.00565% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@e882529). Learn more about missing BASE report. Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 55.00% 9 Missing :warning:
...droid/embracesdk/internal/ndk/EmbraceNdkService.kt 84.84% 2 Missing and 3 partials :warning:
.../internal/comms/delivery/EmbraceDeliveryService.kt 76.47% 1 Missing and 3 partials :warning:
...cesdk/internal/injection/ModuleInitBootstrapper.kt 94.33% 0 Missing and 3 partials :warning:
...ssion/orchestrator/OrchestratorBoundaryDelegate.kt 50.00% 1 Missing :warning:
...esdk/internal/injection/NativeFeatureModuleImpl.kt 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299/graphs/tree.svg?width=650&height=150&src=pr&token=4kNC8ceoVB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## master #1299 +/- ## ========================================= Coverage ? 82.94% ========================================= Files ? 481 Lines ? 11110 Branches ? 1695 ========================================= Hits ? 9215 Misses ? 1160 Partials ? 735 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [.../connectivity/EmbraceNetworkConnectivityService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcapture%2Fconnectivity%2FEmbraceNetworkConnectivityService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NhcHR1cmUvY29ubmVjdGl2aXR5L0VtYnJhY2VOZXR3b3JrQ29ubmVjdGl2aXR5U2VydmljZS5rdA==) | `70.00% <100.00%> (ø)` | | | [...nternal/capture/metadata/EmbraceMetadataService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcapture%2Fmetadata%2FEmbraceMetadataService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NhcHR1cmUvbWV0YWRhdGEvRW1icmFjZU1ldGFkYXRhU2VydmljZS5rdA==) | `90.58% <100.00%> (ø)` | | | [...embracesdk/internal/comms/api/EmbraceApiService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fapi%2FEmbraceApiService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2FwaS9FbWJyYWNlQXBpU2VydmljZS5rdA==) | `91.11% <ø> (ø)` | | | [...dk/internal/comms/delivery/DeliveryCacheManager.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FDeliveryCacheManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0RlbGl2ZXJ5Q2FjaGVNYW5hZ2VyLmt0) | `100.00% <ø> (ø)` | | | [...rnal/comms/delivery/EmbraceDeliveryCacheManager.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FEmbraceDeliveryCacheManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0VtYnJhY2VEZWxpdmVyeUNhY2hlTWFuYWdlci5rdA==) | `84.78% <ø> (ø)` | | | [...sdk/internal/comms/delivery/NoopDeliveryService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FNoopDeliveryService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L05vb3BEZWxpdmVyeVNlcnZpY2Uua3Q=) | `0.00% <ø> (ø)` | | | [...embracesdk/internal/config/EmbraceConfigService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fconfig%2FEmbraceConfigService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbmZpZy9FbWJyYWNlQ29uZmlnU2VydmljZS5rdA==) | `91.04% <ø> (ø)` | | | [...dk/internal/config/behavior/SdkModeBehaviorImpl.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fconfig%2Fbehavior%2FSdkModeBehaviorImpl.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbmZpZy9iZWhhdmlvci9TZGtNb2RlQmVoYXZpb3JJbXBsLmt0) | `82.35% <ø> (ø)` | | | [...mbracesdk/internal/injection/DeliveryModuleImpl.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Finjection%2FDeliveryModuleImpl.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2luamVjdGlvbi9EZWxpdmVyeU1vZHVsZUltcGwua3Q=) | `80.00% <ø> (ø)` | | | [...cesdk/internal/injection/DeliveryModuleSupplier.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Finjection%2FDeliveryModuleSupplier.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2luamVjdGlvbi9EZWxpdmVyeU1vZHVsZVN1cHBsaWVyLmt0) | `100.00% <ø> (ø)` | | | ... and [22 more](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1299?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | |