search

embrace-io / embrace-android-sdk

Embrace mobile performance monitoring SDK for Android
https://embrace.io/docs/android/
Apache License 2.0
132 stars 8 forks source link

[WIP] remove unnecessary ndk code #1302

Closed fractalwrench closed 2 weeks ago

fractalwrench commented 2 weeks ago

Goal

Removes unnecessary NDK code given that NativeCrashDataSourceImpl is actually responsible for sending native crashes these days.

TODO:

Testing

TODO

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.16%. Comparing base (7b54982) to head (3fa8990).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302/graphs/tree.svg?width=650&height=150&src=pr&token=4kNC8ceoVB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## refactor-native-metadata #1302 +/- ## ============================================================ - Coverage 83.27% 83.16% -0.11% ============================================================ Files 481 480 -1 Lines 11245 11140 -105 Branches 1718 1703 -15 ============================================================ - Hits 9364 9265 -99 - Misses 1139 1142 +3 + Partials 742 733 -9 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [...al/capture/session/SessionPropertiesServiceImpl.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcapture%2Fsession%2FSessionPropertiesServiceImpl.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NhcHR1cmUvc2Vzc2lvbi9TZXNzaW9uUHJvcGVydGllc1NlcnZpY2VJbXBsLmt0) | `71.42% <100.00%> (ø)` | | | [...acesdk/internal/capture/user/EmbraceUserService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcapture%2Fuser%2FEmbraceUserService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NhcHR1cmUvdXNlci9FbWJyYWNlVXNlclNlcnZpY2Uua3Q=) | `77.46% <ø> (-0.92%)` | :arrow_down: | | [...embracesdk/internal/comms/api/EmbraceApiService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fapi%2FEmbraceApiService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2FwaS9FbWJyYWNlQXBpU2VydmljZS5rdA==) | `91.11% <ø> (-0.20%)` | :arrow_down: | | [...dk/internal/comms/delivery/DeliveryCacheManager.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FDeliveryCacheManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0RlbGl2ZXJ5Q2FjaGVNYW5hZ2VyLmt0) | `100.00% <ø> (ø)` | | | [...rnal/comms/delivery/EmbraceDeliveryCacheManager.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FEmbraceDeliveryCacheManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0VtYnJhY2VEZWxpdmVyeUNhY2hlTWFuYWdlci5rdA==) | `84.26% <ø> (+0.57%)` | :arrow_up: | | [.../internal/comms/delivery/EmbraceDeliveryService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FEmbraceDeliveryService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L0VtYnJhY2VEZWxpdmVyeVNlcnZpY2Uua3Q=) | `68.49% <ø> (+0.20%)` | :arrow_up: | | [...sdk/internal/comms/delivery/NoopDeliveryService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fcomms%2Fdelivery%2FNoopDeliveryService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2NvbW1zL2RlbGl2ZXJ5L05vb3BEZWxpdmVyeVNlcnZpY2Uua3Q=) | `0.00% <ø> (ø)` | | | [...k/internal/injection/EssentialServiceModuleImpl.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Finjection%2FEssentialServiceModuleImpl.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL2luamVjdGlvbi9Fc3NlbnRpYWxTZXJ2aWNlTW9kdWxlSW1wbC5rdA==) | `97.33% <ø> (-0.04%)` | :arrow_down: | | [...esdk/internal/injection/NativeFeatureModuleImpl.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-features%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Finjection%2FNativeFeatureModuleImpl.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWZlYXR1cmVzL3NyYy9tYWluL2tvdGxpbi9pby9lbWJyYWNlL2FuZHJvaWQvZW1icmFjZXNkay9pbnRlcm5hbC9pbmplY3Rpb24vTmF0aXZlRmVhdHVyZU1vZHVsZUltcGwua3Q=) | `83.01% <ø> (-1.47%)` | :arrow_down: | | [.../internal/injection/NativeFeatureModuleSupplier.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree&filepath=embrace-android-features%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Finjection%2FNativeFeatureModuleSupplier.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWZlYXR1cmVzL3NyYy9tYWluL2tvdGxpbi9pby9lbWJyYWNlL2FuZHJvaWQvZW1icmFjZXNkay9pbnRlcm5hbC9pbmplY3Rpb24vTmF0aXZlRmVhdHVyZU1vZHVsZVN1cHBsaWVyLmt0) | `100.00% <ø> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1302/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)