search

embrace-io / embrace-android-sdk

Embrace's Android SDK built on OpenTelemetry
https://embrace.io/docs/android/
Apache License 2.0
135 stars 11 forks source link

Update profile installer dependency #1307

Closed fractalwrench closed 1 month ago

fractalwrench commented 2 months ago

Goal

The profile installer dependency used in our SDK is using an old version that doesn't have support for newer versions of Android. In this changeset I've generated a baseline profile again using the latest stable version, which will be supported up to API 34. (API 35 support is in a beta version but we can update to that soon).

Profiling

This seems to make a large impact on a OnePlus 7 running Android 10!

Screenshot 2024-09-02 at 14 55 37 Screenshot 2024-09-02 at 14 55 30
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.99%. Comparing base (a0c8381) to head (4c5d35a). Report is 12 commits behind head on tweak-ndk-service.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1307/graphs/tree.svg?width=650&height=150&src=pr&token=4kNC8ceoVB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## tweak-ndk-service #1307 +/- ## ===================================================== + Coverage 82.94% 82.99% +0.04% ===================================================== Files 481 481 Lines 11196 11196 Branches 1706 1706 ===================================================== + Hits 9287 9292 +5 + Misses 1165 1163 -2 + Partials 744 741 -3 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1307/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)