search

embrace-io / embrace-android-sdk

Embrace mobile performance monitoring SDK for Android
https://embrace.io/docs/android/
Apache License 2.0
132 stars 8 forks source link

Remove unused startup status #1308

Closed fractalwrench closed 1 week ago

fractalwrench commented 1 week ago

Goal

The SDK startup status is not used so can be removed. This is read on a background thread so won't have a major impact on startup time.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.94%. Comparing base (4c5d35a) to head (2c6d7dd). Report is 11 commits behind head on tweak-ndk-service.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1308/graphs/tree.svg?width=650&height=150&src=pr&token=4kNC8ceoVB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## tweak-ndk-service #1308 +/- ## ===================================================== - Coverage 82.99% 82.94% -0.05% ===================================================== Files 481 481 Lines 11196 11189 -7 Branches 1706 1706 ===================================================== - Hits 9292 9281 -11 - Misses 1163 1166 +3 - Partials 741 742 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1308?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [...acesdk/internal/prefs/EmbracePreferencesService.kt](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1308?src=pr&el=tree&filepath=embrace-android-core%2Fsrc%2Fmain%2Fkotlin%2Fio%2Fembrace%2Fandroid%2Fembracesdk%2Finternal%2Fprefs%2FEmbracePreferencesService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-ZW1icmFjZS1hbmRyb2lkLWNvcmUvc3JjL21haW4va290bGluL2lvL2VtYnJhY2UvYW5kcm9pZC9lbWJyYWNlc2RrL2ludGVybmFsL3ByZWZzL0VtYnJhY2VQcmVmZXJlbmNlc1NlcnZpY2Uua3Q=) | `91.79% <ø> (-0.41%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-android-sdk/pull/1308/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)