embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Bump OpenTelemetry to new version #123

Closed ArielDemarco closed 2 days ago

ArielDemarco commented 2 weeks ago

Overview

This issue led to the creation of a fix in OpenTelemetrySdk. This PR uses that specific commit/revision as a dependency until a new version of OTel is released.

Additionally, we modified the build_dependencies script to support building dependencies from revisions, branches, and versions extracted from Package.resolved.

Fixes #116

github-actions[bot] commented 2 weeks ago

Dependency Review

The following issues were found:

See the Details below.

License Issues

Package.resolved

PackageVersionLicenseIssue Type
github.com/open-telemetry/opentelemetry-swift>= 0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
swift/github.com/open-telemetry/opentelemetry-swift >= 0 UnknownUnknown

Scanned Files

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.95%. Comparing base (a7acf84) to head (32b361c). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/123/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## main #123 +/- ## ======================================= Coverage 91.94% 91.95% ======================================= Files 410 410 Lines 26604 26604 ======================================= + Hits 24462 24464 +2 + Misses 2142 2140 -2 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/123/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)

🚨 Try these New Features:

ArielDemarco commented 2 days ago

Closing this PR as this one uses an official version of OTel. Will pick up the changes in the build_dependencies script and create another PR with them.