search

embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Fixed a bug preventing crashes from having session properties #130

Closed ArielDemarco closed 1 day ago

ArielDemarco commented 1 day ago

Overview

Crash Reports should have the associated custom properties to the session span. However due tu a misconfiguration of the object that creates the attributes on the crash log, this was not happening. This PR addresses that issue.

github-actions[bot] commented 1 day ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

github-actions[bot] commented 1 day ago
Warnings
:warning: No CHANGELOG entry added.
:warning: No tests added / modified.

Generated by :no_entry_sign: Danger Swift against 08882f1928b5c5c1a9c9bbd6cd38ea4a557138ba

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.88%. Comparing base (584ee27) to head (08882f1). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================== - Coverage 91.95% 91.88% -0.08% ========================================== Files 410 410 Lines 26603 26605 +2 ========================================== - Hits 24462 24445 -17 - Misses 2141 2160 +19 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [...raceCore/Internal/Logs/DefaultInternalLogger.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FInternal%2FLogs%2FDefaultInternalLogger.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9JbnRlcm5hbC9Mb2dzL0RlZmF1bHRJbnRlcm5hbExvZ2dlci5zd2lmdA==) | `87.39% <ø> (-0.11%)` | :arrow_down: | | [...re/Internal/Logs/EmbraceLogAttributesBuilder.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FInternal%2FLogs%2FEmbraceLogAttributesBuilder.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9JbnRlcm5hbC9Mb2dzL0VtYnJhY2VMb2dBdHRyaWJ1dGVzQnVpbGRlci5zd2lmdA==) | `94.04% <100.00%> (+0.07%)` | :arrow_up: | | [...eCore/Session/DataRecovery/UnsentDataHandler.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FSession%2FDataRecovery%2FUnsentDataHandler.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9TZXNzaW9uL0RhdGFSZWNvdmVyeS9VbnNlbnREYXRhSGFuZGxlci5zd2lmdA==) | `93.87% <100.00%> (-0.37%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/130/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)