search

embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Updates `EmbraceResourceProvider` to provide OTel `Resource` directly #40

Closed atreat closed 3 months ago

github-actions[bot] commented 3 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] commented 3 months ago
Warnings
:warning: Please provide a description for the changes in this Pull Request.
:warning: No CHANGELOG entry added.

Generated by :no_entry_sign: Danger Swift against 7d04912547e9ac1cfb8a16efe2f4e87e596c79ce

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (7681243) to head (7d04912). Report is 6 commits behind head on main.

Files Patch % Lines
...ternalTests/Mocks/SpyEmbraceResourceProvider.swift 0.00% 3 Missing :warning:
...ourceStorageExporter/ResourceStorageExporter.swift 85.71% 2 Missing :warning:
.../Internal/Logs/EmbraceLoggerSharedStateTests.swift 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 91.71% 91.77% +0.05% ========================================== Files 387 389 +2 Lines 18368 18690 +322 ========================================== + Hits 16847 17152 +305 - Misses 1521 1538 +17 ``` | [Files](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [...eTests/Internal/ResourceStorageExporterTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&filepath=Tests%2FEmbraceCoreTests%2FInternal%2FResourceStorageExporterTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZUNvcmVUZXN0cy9JbnRlcm5hbC9SZXNvdXJjZVN0b3JhZ2VFeHBvcnRlclRlc3RzLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [...rnalTests/Mocks/DummyEmbraceResourceProvider.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&filepath=Tests%2FEmbraceOTelInternalTests%2FMocks%2FDummyEmbraceResourceProvider.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZU9UZWxJbnRlcm5hbFRlc3RzL01vY2tzL0R1bW15RW1icmFjZVJlc291cmNlUHJvdmlkZXIuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [...nalTests/Shared/EmbraceResourceProviderTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&filepath=Tests%2FEmbraceOTelInternalTests%2FShared%2FEmbraceResourceProviderTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZU9UZWxJbnRlcm5hbFRlc3RzL1NoYXJlZC9FbWJyYWNlUmVzb3VyY2VQcm92aWRlclRlc3RzLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [.../Internal/Logs/EmbraceLoggerSharedStateTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&filepath=Tests%2FEmbraceCoreTests%2FInternal%2FLogs%2FEmbraceLoggerSharedStateTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZUNvcmVUZXN0cy9JbnRlcm5hbC9Mb2dzL0VtYnJhY2VMb2dnZXJTaGFyZWRTdGF0ZVRlc3RzLnN3aWZ0) | `89.65% <0.00%> (ø)` | | | [...ourceStorageExporter/ResourceStorageExporter.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FInternal%2FResourceStorageExporter%2FResourceStorageExporter.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9JbnRlcm5hbC9SZXNvdXJjZVN0b3JhZ2VFeHBvcnRlci9SZXNvdXJjZVN0b3JhZ2VFeHBvcnRlci5zd2lmdA==) | `75.00% <85.71%> (-6.82%)` | :arrow_down: | | [...ternalTests/Mocks/SpyEmbraceResourceProvider.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40?src=pr&el=tree&filepath=Tests%2FEmbraceOTelInternalTests%2FMocks%2FSpyEmbraceResourceProvider.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZU9UZWxJbnRlcm5hbFRlc3RzL01vY2tzL1NweUVtYnJhY2VSZXNvdXJjZVByb3ZpZGVyLnN3aWZ0) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | ... and [48 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/40/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)