embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Fixing recovered logs not having resources from the session #66

Closed NachoEmbrace closed 2 months ago

NachoEmbrace commented 2 months ago
github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] commented 2 months ago
Warnings
:warning: No CHANGELOG entry added.
:warning: **Sources/EmbraceCore/Internal/Logs/Exporter/DefaultLogBatcher.swift#L62** - TODOs should be resolved (Add cleanup step:) (`todo`)

Generated by :no_entry_sign: Danger Swift against fdc2fa35eb4f706be1e30241678bbb22868d5473

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.80240% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.10%. Comparing base (f6f2a90) to head (fdc2fa3). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rces/EmbraceCore/Internal/Logs/LogController.swift 95.65% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== + Coverage 91.78% 92.10% +0.32% ========================================== Files 403 403 Lines 25931 26054 +123 ========================================== + Hits 23800 23998 +198 + Misses 2131 2056 -75 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [Sources/EmbraceCore/Embrace.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FEmbrace.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9FbWJyYWNlLnN3aWZ0) | `84.10% <100.00%> (+3.06%)` | :arrow_up: | | [...ore/Internal/Logs/Exporter/DefaultLogBatcher.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FInternal%2FLogs%2FExporter%2FDefaultLogBatcher.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9JbnRlcm5hbC9Mb2dzL0V4cG9ydGVyL0RlZmF1bHRMb2dCYXRjaGVyLnN3aWZ0) | `100.00% <ø> (+1.40%)` | :arrow_up: | | [...rnal/Logs/Exporter/StorageEmbraceLogExporter.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FInternal%2FLogs%2FExporter%2FStorageEmbraceLogExporter.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9JbnRlcm5hbC9Mb2dzL0V4cG9ydGVyL1N0b3JhZ2VFbWJyYWNlTG9nRXhwb3J0ZXIuc3dpZnQ=) | `93.33% <100.00%> (+1.53%)` | :arrow_up: | | [Sources/EmbraceCore/Public/Embrace+OTel.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FPublic%2FEmbrace%2BOTel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9QdWJsaWMvRW1icmFjZStPVGVsLnN3aWZ0) | `70.75% <100.00%> (ø)` | | | [...eCore/Session/DataRecovery/UnsentDataHandler.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FSession%2FDataRecovery%2FUnsentDataHandler.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9TZXNzaW9uL0RhdGFSZWNvdmVyeS9VbnNlbnREYXRhSGFuZGxlci5zd2lmdA==) | `94.23% <100.00%> (+0.07%)` | :arrow_up: | | [...Logs/Exporter/StorageEmbraceLogExporterTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Tests%2FEmbraceCoreTests%2FInternal%2FLogs%2FExporter%2FStorageEmbraceLogExporterTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZUNvcmVUZXN0cy9JbnRlcm5hbC9Mb2dzL0V4cG9ydGVyL1N0b3JhZ2VFbWJyYWNlTG9nRXhwb3J0ZXJUZXN0cy5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | [...ceCoreTests/Internal/Logs/LogControllerTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Tests%2FEmbraceCoreTests%2FInternal%2FLogs%2FLogControllerTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZUNvcmVUZXN0cy9JbnRlcm5hbC9Mb2dzL0xvZ0NvbnRyb2xsZXJUZXN0cy5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | [...raceCoreTests/Session/UnsentDataHandlerTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Tests%2FEmbraceCoreTests%2FSession%2FUnsentDataHandlerTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZUNvcmVUZXN0cy9TZXNzaW9uL1Vuc2VudERhdGFIYW5kbGVyVGVzdHMuc3dpZnQ=) | `99.59% <100.00%> (+0.01%)` | :arrow_up: | | [...rces/EmbraceCore/Internal/Logs/LogController.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66?src=pr&el=tree&filepath=Sources%2FEmbraceCore%2FInternal%2FLogs%2FLogController.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ29yZS9JbnRlcm5hbC9Mb2dzL0xvZ0NvbnRyb2xsZXIuc3dpZnQ=) | `92.59% <95.65%> (+0.76%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/66/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)