search

embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Using `2.0.4` of `KSCrash` #70

Closed ArielDemarco closed 2 months ago

ArielDemarco commented 2 months ago

Overview

Updated KSCrash dependency to version 2.0.4, which now uses dynamic instead of static linking in SPM. Previously, static linking of KSCrash during the creation of XCFrameworks resulted in duplicated symbols.

Also, building XCFrameworks for unnecessary products from KSCrash has been removed in the build_kscrash.sh script

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.76%. Comparing base (5eb8526) to head (5163639). Report is 1 commits behind head on release/6.4.1.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/70/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## release/6.4.1 #70 +/- ## ================================================= - Coverage 91.84% 91.76% -0.09% ================================================= Files 403 403 Lines 26152 26152 ================================================= - Hits 24020 23998 -22 - Misses 2132 2154 +22 ``` [see 9 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/70/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)