embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Fix `iOS 17.5` < simulators with cocoapods #78

Closed ArielDemarco closed 1 month ago

ArielDemarco commented 2 months ago

Overview

Fixed an issue that would cause a crash when running Embrace with devices with versions lower than iOS 17.5 after installing the SDK with Cocoapods.

github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.92%. Comparing base (fe3675e) to head (f4613d6). Report is 5 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/78/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== - Coverage 91.93% 91.92% -0.01% ========================================== Files 400 400 Lines 26024 26024 ========================================== - Hits 23924 23923 -1 - Misses 2100 2101 +1 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/78/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)
atreat commented 1 month ago

Do we need other platforms defined here too?

ArielDemarco commented 1 month ago

Do we need other platforms defined here too?

Yes, we'd have to define something for tvOS at least at some point; but we don't have enough tests in place to really test this