search

embroider-build / addon-blueprint

Blueprint for v2-formatted Ember addons
MIT License
28 stars 23 forks source link

Add @glint/core to root package.json #265

Closed miguelcobain closed 4 months ago

NullVoxPopuli commented 4 months ago

Looks like ember-data is now requiring Node 20 :sweat_smile: maybe that was a mistake? idk.

SergeAstapov commented 4 months ago

Why this may be needed?

miguelcobain commented 4 months ago

@SergeAstapov without this, you don't get autocomplete in gjs/gts files in vscode.

More info: https://github.com/typed-ember/glint/issues/524

Discord: https://discord.com/channels/480462759797063690/491905849405472769/1211700527285534770

NullVoxPopuli commented 4 months ago

the VSCode extension doesn't, by default, know how to find @glint/core.

If you have a monorepo, The Glint VSCode extension doesn't initially detect a @glint/core dependency and since folks, by default, don't seem to use VSCode's workspace feature to open individual workspaces (and instead opting to open the whole monorepo as a workspace), folks would previously need to configured "Library Path":

So adding @glint/core to the root package.json enables folks' VSCode to "work by default" without additional config

SergeAstapov commented 4 months ago

Thank you for the explanation!