search

embroider-build / addon-blueprint

Blueprint for v2-formatted Ember addons
MIT License
28 stars 23 forks source link

Because TS addons need to emit declarations, we need to set noEmit to false #271

Closed NullVoxPopuli closed 3 months ago

ef4 commented 4 months ago

Perhaps emitDeclarationsOnly.

NullVoxPopuli commented 4 months ago

yeah -- more testing is def needed.

The main thing is that Glint silently fails if you have an invalid tsconfig.json :see_no_evil: hopefully that can be resolved as well, but this PR mostly a reminder to me to actually test stuff locally (I made this PR from browser)

simonihmig commented 4 months ago

Can you share the context here? Why is this needed now, as it used to work just fine before?

NullVoxPopuli commented 4 months ago

if you add emitDeclarationOnly: true, you get silent fail, (exit 0), no declaration.

if you run tsc --decalaration to get debugging info on the config, you get this error:

❯ tsc --declaration
tsconfig.json:17:5 - error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.

17     "emitDeclarationOnly": true,
       ~~~~~~~~~~~~~~~~~~~~~

Found 1 error in tsconfig.json:17
NullVoxPopuli commented 4 months ago

Updated the config

NullVoxPopuli commented 3 months ago

Re-opened here: https://github.com/embroider-build/addon-blueprint/pull/277