embroider-build / addon-blueprint

Blueprint for v2-formatted Ember addons
MIT License
29 stars 28 forks source link

Option `addon-location` is ignored #301

Open fpauser opened 1 week ago

fpauser commented 1 week ago

Executed in an ember monorepo to generate a v2 addon without testapp in the ./packages/ directory:

ember addon "@app-namespace/addon-v2" -b @embroider/addon-blueprint \
  --pnpm \
  --addon-only \
  --addon-location="packages/addon-v2" \
  --skip-git --typescript

This prints the following warning:

The option '--addon-only' is not registered with the 'addon' command. Run `ember addon --help` for a list of supported options.
The option '--addon-location' is not registered with the 'addon' command. Run `ember addon --help` for a list of supported options.

and puts the addon-v2 addon directly into the monorepo root, instead of the ./packages/ directory as intended.

ember version:

$ ember -v
ember-cli: 5.12.0
node: 20.17.0
os: linux x64

pnpm version:

$ pnpm -v
9.9.0
NullVoxPopuli commented 1 week ago

When using --addon-only, you want to cd to the directory where you want the addon to be. (the testing matrix is too big otherwise 😅 )

Re the ember-cli warnings, we/someone needs to add formal support for the addon and new blueprints having custom flags.