simonihmig
commented
2 years ago Out of the box, yarn test at the top-level emits a confusing warning because it runs the test script in every package and the test script in the addon just echos a warning.
Yes, not quite ideal... we use yarn workspaces run test to automatically run tests for all workspaces. E.g. by adding another test-app, it's tests would run in CI automatically, which otherwise you could easily miss to add explicitly. However not having a test script would fail that command IIRC, so the addon basically has just a dummy script. Should we make the addon echo a different (less confusing) message, or just do a no-op? (I think the current message is useful, if you run test explicitly inside the addon folder. But less so, when run as part of the global test...)
Also, the current setup runs linting in CI twice, because it runs both yarn lint as a dedicated step, but also includes linting in the test-app's test script.
Hm, right. This merging of linting and tests comes from Ember's app blueprint. Not sure if that really makes so much sense, but it's nothing we can change easily, or at least would require overriding after the app blueprint ran. We could make the global test script call test:ember, but that would again work against this generalization concept of the global test delegating to each test of its workspaces mentioned above...
NullVoxPopuli
Out of the box,
yarn testat the top-level emits a confusing warning because it runs thetestscript in every package and thetestscript in the addon just echos a warning.Also, the current setup runs linting in CI twice, because it runs both
yarn lintas a dedicated step, but also includes linting in the test-app'stestscript.