embroider-build / app-blueprint

[pre-alpha™️] Blueprint for next generation of Ember apps
26 stars 6 forks source link

using `ember init` to update projects made with this blueprint fails if you're already removed ember-fetch, etc #52

Closed NullVoxPopuli closed 17 hours ago

NullVoxPopuli commented 1 month ago

error:

🚧  Installing packages... This might take a couple of minutes.
pnpm: Installed @embroider/core@unstable, @embroider/vite@unstable and 5 other packages

🚧  Installing packages... This might take a couple of minutes.
Command failed with exit code 1: pnpm remove ember-fetch broccoli-asset-rev ember-cli-app-version ember-cli-clean-css ember-cli-dependency-checker ember-cli-sri ember-cli-terser
 ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS  Cannot remove 'ember-fetch', 'broccoli-asset-rev', 'ember-cli-app-version', 'ember-cli-clean-css', 'ember-cli-dependency-checker', 'ember-cli-sri', 'ember-cli-terser': no such dependencies found

why use ember init?

ember-cli-update requires a valid ember-cli-update.json config -- so how do you get your first ember-cli-update.json config? :see_no_evil:

MichalBryxi commented 2 days ago

Having the same issue and wondering if cheap solution around this would be to change this code to something like:

    const packages = ['ember-fetch',
        'broccoli-asset-rev',
        'ember-cli-app-version',
        'ember-cli-clean-css',
        'ember-cli-dependency-checker',
        'ember-cli-sri',
        'ember-cli-terser'];

    for(const package of packages) {
      try {
        await uninstallTask.run({
          'save-dev': true,
          verbose: false,
          packages: [
            package
          ],
          packageManager: options.packageManager,
        });
      } catch (e) {
       console.log(`Could not uninstall ${package}`);
      }
   }

Would do the trick?

I'm running following command over embroider-webpack enabled repo:

pnpm dlx ember-cli@latest init -b @embroider/app-blueprint --pnpm --name winds-mobi-client-web