Closed NullVoxPopuli closed 6 days ago
@NullVoxPopuli This is a bit hard to review now with all the stuff included that has been extracted into their own PRs. Could you please ping us again, when those extractions have been merged and this rebased?
Thanks for working on this, this is much needed! (for some people at least 🙂 )
of course yes! I don't know how to un-ping people once I put a PR back in to draft status 🙈
@NullVoxPopuli Can I help getting this merged please?
For testing this out (without cloning), I published this branch under
@nullvoxpopuli/ember-vite-app
So, creating a TS app would happen like:
Extractions
- https://github.com/embroider-build/app-blueprint/pull/81 - https://github.com/embroider-build/app-blueprint/pull/82 - https://github.com/embroider-build/app-blueprint/pull/83 - https://github.com/embroider-build/app-blueprint/pull/84 - https://github.com/embroider-build/app-blueprint/pull/88 - https://github.com/embroider-build/app-blueprint/pull/87 - https://github.com/embroider-build/app-blueprint/pull/93 - https://github.com/embroider-build/app-blueprint/pull/94 - https://github.com/embroider-build/app-blueprint/pull/99 - https://github.com/ember-cli/ember-cli/pull/10515 - https://github.com/ember-cli/ember-cli/pull/10516The upstream blueprint supports
--typescript
, and a fair number of folks wanting "to try out the Vite blueprint" want to use TypeScript.The effort required here isn't huge, mostly config changes.
The Approach:
--typescript
optionWhat isn't implemented:
These will show up in future PRs (as this one is already quite big) -- and how we want to teach ember-data in the future also doesn't include models, so I'll need to sink with @runspired on what the strategy should be there (or if ember-data/warp-drive has its own generator, etc (since it's meant to be very "use what you need"))