search

embroider-build / app-blueprint

[pre-alpha™️] Blueprint for next generation of Ember apps
26 stars 6 forks source link

Set type=module #92

Open NullVoxPopuli opened 1 day ago

NullVoxPopuli commented 1 day ago

do not merge (yet)

mansona commented 1 day ago

Dude we're no where near being able to do this 😂 ember-cli is going to have such a hard time with the prebuild 😭

NullVoxPopuli commented 1 day ago

I had to know :p

NullVoxPopuli commented 1 day ago

Looks like the first problem I run in to is that loadConfigFromMeta from @embroider/config-meta-loader did not find the environment.cjs file.

But renaming it to js, gives an error from ember-cli, as you predicted -- from ember-cli/lib/models/project -- which makes sense as ember-cli magically looks for that file.

but if I just inline what I need in app/config/environment.js, it boots.... so I think we're actually really close, and we could have app type=module support with a lil'change to embroider 🤔

(or we need more tests somewhere)

NullVoxPopuli commented 1 day ago

This is unexpected

not ok 1 Firefox - [undefined ms] - error
Stderr: 
 Error: no DISPLAY environment variable specified

not ok 2 Edge - [undefined ms] - error
Stderr: 
 [2795:2795:0928/193403.938523:ERROR:ozone_platform_x11.cc(244)] Missing X server or $DISPLAY
 [2795:2795:0928/193403.938548:ERROR:env.cc(258)] The platform failed to initialize.  Exiting.

not ok 3 Chromium - [undefined ms] - error
  Stderr: 
   [2826:2826:0928/193405.322119: