Closed NullVoxPopuli closed 6 months ago
yes, if this did the same thing meaning npm run build the two would be in sync
On Fri, Dec 1, 2023, 22:58 NullVoxPopuli @.***> wrote:
@.**** commented on this pull request.
In .github/workflows/ci.yml https://github.com/embroider-build/content-tag/pull/44#discussion_r1412642100 :
cache: 'npm'
- run: npm ci
- run: ./build.sh
the release workflow already run npm run build, so this is covered
— Reply to this email directly, view it on GitHub https://github.com/embroider-build/content-tag/pull/44#discussion_r1412642100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHPNIYA6WWEOZLJLNEWL23YHJOHRAVCNFSM6AAAAABADKFMUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRQGY3TGMJTGM . You are receiving this because you commented.Message ID: @.***>
Alternative to: https://github.com/embroider-build/content-tag/pull/41
Changes:
files
entry includes thepkg
directoryexports
with conditional/subpath entries to target node/browser separately since wasm-pack generates very different output for each target (there isn't a need for this if they went for full async-only API, but :shrug: )vite
has for https://github.com/vitejs/vite/issues/9731 -- which is settingresolve-alias
for"package-name": "."
(current directory) so that vite can resolve the "self's" exports. So we currently don't have automated browser testing atm. We could set up qunit instead of vitest, but we currently need to handroll a reporter to the CLI, because vite/vitest haven't given us those APIs to build custom reporters. GlimmerVM is already doing this, so it "just" needs to be extracted. This is the error:publint
and@arethetypeswrong/cli
to help me be more confident that the package.json was correctly configured so we don't have to rapid publishes to fix bugs with package.json config.@arethetypeswrong/cli
reported some issues which are resolved now. One being this issue which is resolved by using node newer than 16 -- which... we don't declare node support at all, and node 16 is EOL'd so it seems fine to bump the CI's node.In a real app
because my confidence in non-monorepo layouts is way lower (can't test with real projects with real module resolution),
here is a real usage:
PR to my repl here: https://github.com/NullVoxPopuli/limber/pull/1546 Results:
export async function preprocess(input: string, name: string): Promise {
if (!fetchingPromise) {
fetchingPromise = import('content-tag');
}
if (!processor) { let { Preprocessor } = await fetchingPromise;
}
return processor.process(input,
${name}.js
); }but this is due to: https://github.com/embroider-build/embroider/issues/1678 and this code likely would work once that 1678 issue is resolved.