embroider-build / content-tag

A rust program that uses my swc fork to parse GJS
MIT License
7 stars 7 forks source link

Standalone content-tag implemented via conditional exports in package.json #44

Closed NullVoxPopuli closed 6 months ago

NullVoxPopuli commented 7 months ago

Alternative to: https://github.com/embroider-build/content-tag/pull/41

Changes:


In a real app

because my confidence in non-monorepo layouts is way lower (can't test with real projects with real module resolution),

here is a real usage:

void-mAlex commented 7 months ago

yes, if this did the same thing meaning npm run build the two would be in sync

On Fri, Dec 1, 2023, 22:58 NullVoxPopuli @.***> wrote:

@.**** commented on this pull request.

In .github/workflows/ci.yml https://github.com/embroider-build/content-tag/pull/44#discussion_r1412642100 :

     cache: 'npm'
    • run: npm ci
    • run: ./build.sh

the release workflow already run npm run build, so this is covered

— Reply to this email directly, view it on GitHub https://github.com/embroider-build/content-tag/pull/44#discussion_r1412642100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHPNIYA6WWEOZLJLNEWL23YHJOHRAVCNFSM6AAAAABADKFMUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRQGY3TGMJTGM . You are receiving this because you commented.Message ID: @.***>