embroider-build / create-release-plan-setup

MIT License
6 stars 6 forks source link

package.json keys sorting is deeply changed after running this tool #63

Open NullVoxPopuli opened 7 months ago

NullVoxPopuli commented 7 months ago

Normally :shrug: , but this has an impact on exports, since the order of those matters. (types must come before default, but alphabetically, types is after default)

mansona commented 7 months ago

This is because of sort-package-json, if it's an issue then we should probably open an issue up there https://github.com/keithamus/sort-package-json

NullVoxPopuli commented 7 months ago

what if a repo doesn't use that specific package for sorting?

bertdeblock commented 6 months ago

Maybe just sorting the dev dependencies would be less noisy?

Something like:

const { devDependencies: sortedDevDependencies } = sortPackageJson({
  devDependencies: pkg.devDependencies
});

pkg.devDependencies = sortedDevDependencies;