embroider-build / create-release-plan-setup

MIT License
6 stars 6 forks source link

Sometimes _a_ command needs to run before publish (due to a pnpm bug? idk) #85

Open NullVoxPopuli opened 8 months ago

NullVoxPopuli commented 8 months ago

scenario:

# .npmrc in the repo
ignore-scripts=true

then,

pnpm publish

and then prepack doesn't run 😩 which I believe is a bug, as ignore-scripts is not supposed to mean all scripts, and should actually be fixed in pnpm. See also:

(this is about prepublishOnly, but it's "a" lifecycle hook -- ignore-scripts was only meant for install-based lifecycles, afaict)

idk if it makes sense to add a --build-command="pnpm build" to create-release-plan-setup?

like, this is what I've added for now: https://github.com/NullVoxPopuli/ember-data-resources/pull/408/files#diff-551d1fcf87f78cc3bc18a7b332a4dc5d8773a512062df881c5aba28a6f5c48d7R57