search

embroider-build / ember-auto-import

Zero config import from npm packages
Other
360 stars 109 forks source link

avoid unnecssary full page reloads #510

Closed ef4 closed 2 years ago

ef4 commented 2 years ago

Possible fix for #469

gilest commented 2 years ago

Looks good. Tried to test with the repro in #469 but ran into roadblocks installing ember-auto-import from git branch (monorepo issue) or local directory (breaks version check).

Let me know if there's a way I can help.

SergeAstapov commented 2 years ago

Looks good. Tried to test with the repro in #469 but ran into roadblocks installing ember-auto-import from git branch (monorepo issue) or local directory (breaks version check).

just an idea, you may try to run npm pack in ember-auto-import branch with the fix to get tgz file and use file: scheme in package.json (followed by yarn i/npm i/pnpm i) to point to that file from the app to test the changes. Otherwise there is no easy way to point to package from monorepo (git submodules may be other option but that’s way to wild 😝 imo)

gilest commented 2 years ago

you may try to run npm pack in ember-auto-import branch with the fix to get tgz file and use file: scheme in package.json (followed by yarn i/npm i/pnpm i) to point to that file from the app to test the changes

Ah – thanks! I hadn't tried this... but it still fails the version check.

ember-auto-import was unable to find any copy of itself that satisfies the app's requested range of file:/Users/giles/code/ember-auto-import-2.4.0.tgz

Anyway I patched past the version check by editing the leader.js in node_modules and hardcoding the appCandidate version.

I can no longer repro the bug with this version 🙌🏻

ef4 commented 2 years ago

This is released now anyway. Thanks.