search

embroider-build / ember-auto-import

Zero config import from npm packages
Other
360 stars 109 forks source link

Fix `style-loader` not being in effect in `production` environments #518

Closed boris-petrov closed 2 years ago

boris-petrov commented 2 years ago

Fixes #514.

@ef4 - I believe the issue is here coming from this commit - in production environment eai-style-loader is not loaded at all. Not sure why this was done - this PR sets style-loader to load in all cases.

boris-petrov commented 2 years ago

I've made that eai-style-loader runs after MiniCssExtractPlugin.loader - not sure if that is correct. Is that why the tests are failing?

ef4 commented 2 years ago

It was intentional that we don't use style-loader in production. style-loader's own docs say it's not recommend for production use and to use MiniCssExtractPlugin instead, and that you should never use both together simultaneously.

boris-petrov commented 2 years ago

As was noted in the issue, this PR is not required. Closing.