search

embroider-build / ember-auto-import

Zero config import from npm packages
Other
360 stars 109 forks source link

Allow disabling sourcemaps when forbidEval is set (v1.x) #520

Closed apellerano-pw closed 2 years ago

apellerano-pw commented 2 years ago

Fixes #444 for 1.x

I went with @ef4's advice to give precedence to the user's webpack config.

I tried to write a unit test for Bundler.bundlerHook, but the stubbing rabbit hole went too deep. Happy to try again if you have advice for how to test my change.

Aside: When I tried to get local development set up for tags/v1.12.1, npm i would fail due to an integrity mismatch on ef4/node-fixturify-project. (See commit message for error log.) I healed the package-lock by deleting and re-adding the package, which did some minor bumps. I figure since you own both packages you can speak to the source & legitimacy of the integrity mismatch.

ef4 commented 2 years ago

Thanks, I cherry picked the changes onto #523, the integrity mismatch thing was not something I could reproduce.

ef4 commented 2 years ago

Published in 1.12.2.

ef4 commented 2 years ago

This is the corresponding fix for the 2.x series https://github.com/ef4/ember-auto-import/pull/524