search

embroider-build / ember-auto-import

Zero config import from npm packages
Other
360 stars 109 forks source link

Add v1 addons that could be consumed by v2 addons in module-scope to … #553

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

…a list that loads them earlier in AMD

Partially resolves: https://github.com/ef4/ember-auto-import/issues/504

NullVoxPopuli commented 1 year ago

@ef4 I'm unsure of the value of the added test -- it seems this bug is really really hard to reproduce.

however I was able to yarn link ember-auto-import to my problematic apps, and confirm that this addresses the issue those apps were facing.

ef4 commented 1 year ago

Next step here is to remove things from the early boot set when their corresponding real package isn't in the app's package.json dependencies / devDependencies. This comes up in the test suite because our oldest supported ember doesn't support @glimmer/tracking.

NullVoxPopuli commented 1 year ago

The fun deepens. on that ember-source 3.4 + fastboot scenario, we get (after removing @glimmer/tracking from the early boot set because it is not present in the package.json):

loader.js:247 Uncaught Error: Could not find module `@ember/service/index` imported from `__v1-addons__early-boot-set__`

and yet, here it is 🙃 (actually in vendor.js) image

NullVoxPopuli commented 1 year ago

I disabled the feature entirely for old ember.

NullVoxPopuli commented 1 year ago

Green, sans ie11 timeout