search

embroider-build / ember-auto-import

Zero config import from npm packages
Other
360 stars 109 forks source link

Fix missing babel-plugin-ember-template-compilation dependency #576

Closed mansona closed 1 year ago

mansona commented 1 year ago

Since #573 we have the possibility that we can require babel-plugin-ember-template-compilation so it needs to be an active dependency of ember-auto-import

I did some digging and I couldn't quite figure out why this was not caught in our tests here in ember-auto-import but it was caught in the embroider tests 🤔

I also have no idea why the typescript stuff was throwing errors for me when I was trying to npm install this change but 🤷 I made the change to make it work

ef4 commented 1 year ago

I merged your first commit with the actual fix, not your second with the typescript stuff. You had some local problem that gave you the wrong typescript version. Fixes something like this will be needed when we upgrade typescript but don't belong in this bug fix PR.

ef4 commented 1 year ago

Released in 2.6.3