embroider-build / embroider

Compiling Ember apps into spec-compliant, modern Javascript.
MIT License
337 stars 136 forks source link

dependencySatisfies + macroCondition ignores ember-source >= 4.0.0Z #1057

Closed NullVoxPopuli closed 2 years ago

NullVoxPopuli commented 2 years ago

I found an incorrect modifier manager right now: image

and without sourcemaps: image

I'm using ember-source-4.2-alpha.4

NullVoxPopuli commented 2 years ago

I wonder if this is related to: https://github.com/embroider-build/embroider/issues/1038

which, I took a stab at fixing here: https://github.com/embroider-build/embroider/pull/1053

but I don't know what's supposed to happen.

ef4 commented 2 years ago

I think this was fixed in #1053.

NullVoxPopuli commented 2 years ago

I don't think this is resolved: image

(unless #1053 isn't released?)

NullVoxPopuli commented 2 years ago
if ((0,_home_nullvoxpopuli_Development_NullVoxPopuli_limber_node_modules_embroider_macros_src_addon_runtime__WEBPACK_IMPORTED_MODULE_0__.macroCondition)(false)) {
  // new enough ember has a real module we can import
  runtime = __webpack_require__(/*! ../../../../externals/@glimmer/runtime */ "../../externals/@glimmer/runtime.js");
} else {
  // older ember has its own internal loader
  runtime = window.Ember.__loader.require('@glimmer/runtime');
}