Closed thoov closed 2 years ago
I just remembered where those window.define
are coming from. They're extraImports
being added by a packageRule.
And their behavior changed in 0.49.0: https://github.com/embroider-build/embroider/pull/1043
The part that's likely to be relevant is
Which started inserting an importSync
, which will itself get further transformed by the macros-babel-plugin.
Some combination of those two things is what's emitting these weird relative paths.
Steps to reproduce:
ember install ember-cli-mirage@0.4.9
packageRules: [{
package: 'ember-cli-mirage',
addonModules: {
'get-rfc232-test-context.js': { dependsOnModules: ['@ember/test-helpers'] }
}
}],
ember s
, you should see the error in the browser's console and the page will not renderFixed in #1081
Starting in v0.49.0+ I am seeing this error (v0.47.0 & v0.48.0 worked fine):
getRfc232TestContext module looks like:
Specifically these lines cause problems:
I am also seeing this happen in other modules as well where it is creating
../module-name/index.js
and throwing an error.In v0.48.0 this is what the module looked like: