Support `ember` key in package.json (instead of `ember-addon`)

embroider-build / embroider

Compiling Ember apps into spec-compliant, modern Javascript.

MIT License

337 stars 137 forks source link

Support `ember` key in package.json (instead of `ember-addon`) #1226

Open chancancode opened 2 years ago

chancancode commented 2 years ago

See https://github.com/emberjs/rfcs/pull/823

It was an intention change during the RFC process. We'll probably have to support both for the foreseeable future.

NullVoxPopuli commented 2 years ago

will the two be merged?

if ember-addon specifies stuff in ember, and there are conflicts, should we throw an error? maybe lint:fix things into ember?

chancancode commented 2 years ago

I think it should probably throw, yeah. "ember-addon" should be considered legacy once this is available. In practice we may be able to go around and change most of the v2 addons we know about pretty quickly.