dependencySatisfies doesn't work properly with optional peer dependencies

[anehx]

Hi

I'm having problems with the dependencySatisfies macro. I have an addon that defines a peer dependency as optional. The addon code then uses dependencySatisfies to check whether I need to implement a function (including an import of that dependency).

However, if I use that addon in an app that does not have that dependency, the macro still resolves to true which causes an error of ember-auto-import:

ember-simple-auth-oidc tried to import "@apollo/client" in "ember-simple-auth-oidc/apollo.js" but the package was not resolvable

@apollo/client is not present in the dependencies, I verfied that with yarn why @apollo/client.

Here are the relevant code snippets of the addon:

• peer dependency definition: https://github.com/adfinis/ember-simple-auth-oidc/blob/3c69b18222cbe4e296655f398221208b456867e8/package.json#L83-L90
• code using the macro: https://github.com/adfinis/ember-simple-auth-oidc/blob/3c69b18222cbe4e296655f398221208b456867e8/addon/apollo.js#L11-L36

Could you take a look at that? Let me know if I can do something to help..

[Windvis]

I believe this is an ember-auto-import issue. The error is thrown here.

dependencySatisfies does return false correctly but I think ember-auto-import simply analyzes all imports and doesn't check for optional peerDependencies yet. I'm not familiar enough with the code (and intended workings) to know what the correct solution is but this is at least a first pointer for the real issue 😄.

[ef4]

We just fixed a very similar case in https://github.com/ef4/ember-auto-import/pull/530 by moving an error from build time to runtime.

It would make sense to do the same for importSync for the same reason.