search

embroider-build / embroider

Compiling Ember apps into spec-compliant, modern Javascript.
MIT License
339 stars 137 forks source link

Stylelint files missing from instructions in docs/porting-addons-to-v2.md #1562

Open fdeters opened 1 year ago

fdeters commented 1 year ago

Hello! I noticed that .stylelintrc.js and .stylelintignore are missing from the instructions in step 18 of part 1 of the v2 addon porting instructions:

  1. At this point all tests and lint scripts work the same way as before inside the test-app. But we will also want linting, prettier, etc for the newly-separated addon workspace too. ... Copy .gitignore, .eslintrc.js, .eslintignore, .prettierrc.js, .prettierignore, and .template-lintrc.js from test-app to addon.

Without copying those two files over to the addon, the lint:css scripts don't work.

fdeters commented 1 year ago

Looking at it again, the real problem is probably that the stylelint packages are missing from this section of step 18 as well:

Copy eslint, relevant eslint plugins, prettier, ember-template-lint, and npm-run-all from test-app/package.json devDependencies to addon/package.json devDependencies.

I believe stylelint, stylelint-config-standard, and stylelint-prettier all need to be moved?

NullVoxPopuli commented 1 year ago

yes -- stylelint was added to the blueprint after that document was written 🙃