ef4
commented
3 months ago Your working example is using Vite and your failing example is using Webpack. Are you sure this plugin actually works in standalone webpack? Because I have seen very poor support for virtual-file-like unplugins in webpack.
The "meta failing to propagate" message is because your virtual file is presenting itself as /full/path/to/kolay/docs-app/_virtual_%00kolay%2Fsetup. That is a nonsensical place for it to be because webpack is not building an app in /full/path/to/kolay, it's building an app in /full/path/to/kolay/node_modules/.embroider and nothing in webpack is supposed to even look at the "real" app dir. (This will change when we finish eliminating app rewriting.)
My suggestion is to first confirm that this plugin really works in a vanilla webpack project. If it does, we can look into whether we're missing something that would cause it to get confused about where the app lives.
NullVoxPopuli
Example setup of non-embroider usage to describe what I mean:
code here
The plugins (in a pcakage): ```js /** * This plugin is *basically* what v1 addons did. */ import { stripIndent } from 'common-tags'; import { createUnplugin } from 'unplugin'; import { virtualFile } from './helpers.js'; export const docs = createUnplugin(() => { return { name: 'kolay-docs', ...virtualFile([ { importPath: 'kolay/api-docs:virtual', content: `export const name = 'docs';`, }, { importPath: 'kolay/manifest:virtual', content: `export const name = 'manifest';`, }, ]), }; }); export const setup = createUnplugin(() => { return { name: 'kolay-setup', ...virtualFile([ { importPath: 'kolay/setup', content: stripIndent` export async function setupKolay() { let [apiDocs, manifest] = await Promise.all([ import('kolay/api-docs:virtual'), import('kolay/manifest:virtual'), ]); return { apiDocs, manifest }; } `, }, { importPath: 'kolay/test-support', content: stripIndent` import { setupKolay as setup } from 'kolay/setup'; export function setupKolay() { return setup(); } `, }, ]), }; }); ``` The consumer's main.js: ```js import { setupKolay } from 'kolay/test-support'; console.log(setupKolay); let result = await setupKolay(); console.log(result); ``` expected output: Under embroider v3, the following error is encountered:
error log
``` ================================================================================= ENV Summary: TIME: Fri Mar 01 2024 09:00:52 GMT-0500 (Eastern Standard Time) TITLE: ember ARGV: - 🏠/.volta/tools/image/node/20.10.0/bin/node - <.pnpm>/ember-cli@5.5.0/node_modules/ember-cli/bin/ember - serve EXEC_PATH: 🏠/.volta/tools/image/node/20.10.0/bin/node TMPDIR: /tmp SHELL: /bin/bash PATH: -We don't actually care about embroider resolver's meta in this case.
Some notes on the difference between my working-repro and local-repro (breaking, PR here: https://github.com/universal-ember/kolay/pull/33)
ember-addon