embroider-build / embroider

Compiling Ember apps into spec-compliant, modern Javascript.
MIT License
329 stars 137 forks source link

Public assets handling/ clean up stage 2 #1859

Closed BlueCutOfficial closed 1 month ago

BlueCutOfficial commented 1 month ago

Relates to #1736

Thanks to the new assets plugin, Vite can now serve and emit the public assets provided by the Ember app and addons without using the rewritten-app. It means that copying these assets in the rewritten-app has become an unnecessary step.

This PR does the clean-up by removing the related code from the compat-app-builder along with the tests that use to assert the presence of the public assets in the rewritten-app.