search

embroider-build / embroider

Compiling Ember apps into spec-compliant, modern Javascript.
MIT License
329 stars 137 forks source link

vite: change ext-es format #1900

Closed patricklx closed 4 days ago

ef4 commented 2 weeks ago

This is not a good solution to the problem. I don't want to break the vite resolver every time core decides to add a search param. And what happens if core is using a searchParam but then vite decides to also start using the same name?

We probably don't need to use search params at all in the core. The structure of these URLs were fairly arbitrary decisions. I I think we can make them all part of the pathName, and decide to leave searchParams entirely free for use by the host environment (vite).

patricklx commented 2 weeks ago

@ef4 I updated the pr, the failing checks look unrelated. more related to babel plugin template compilation

ef4 commented 4 days ago

Thanks, looking good.