search

embroider-build / embroider

Compiling Ember apps into spec-compliant, modern Javascript.
MIT License
339 stars 137 forks source link

`sideWatch` is not a function in `@embroider/broccoli-side-watch@1.0.0` #2147

Closed aklkv closed 4 weeks ago

aklkv commented 4 weeks ago

After upgrading to v1.0.0 I started seeing:

sideWatch is not a function

setup is has not changes:

const sideWatch = require('@embroider/broccoli-side-watch');

trees: {
      app: sideWatch('app', { watching: ['../addons'] }),
    },
ijlee2 commented 4 weeks ago

I also ran into the issue. The error goes away if we write,

/* ember-cli-build.js */
const { default: sideWatch } = require('@embroider/broccoli-side-watch');

but suspect that this change was unintentional (the code doesn't match what's shown on the README).

simonihmig commented 4 weeks ago

Fixed in 1.0.1! https://github.com/embroider-build/embroider/releases/tag/v1.0.1-%40embroider%2Fbroccoli-side-watch

Apologies for the trouble!

aklkv commented 4 weeks ago

No worries! Thank you for the quick fix 🙏🏻 I though I would report right away since it was released as stable V1