search

embulk / embulk-base-restclient

Base class library for Embulk plugins to access RESTful services
https://www.embulk.org/
Apache License 2.0
6 stars 7 forks source link

Reconsider the name ServiceResponseSchema. #11

Closed dmikurube closed 7 years ago

dmikurube commented 7 years ago

Maybe ServiceResponseMapper, or else?

muga commented 7 years ago

Agree. I think that ServiceResponseMapper is better. Because the purpose is to create SchemaWriter (it seems that SchemaWriter is also not good so much but). But, I don't have other good candidates.

dmikurube commented 7 years ago

@muga Thanks. Pushed a fixing PR #30.

dmikurube commented 7 years ago

30 is merged. Closing.