search

embulk / embulk-base-restclient

Base class library for Embulk plugins to access RESTful services
https://www.embulk.org/
Apache License 2.0
6 stars 7 forks source link

Build |ServiceResponseSchema| based on |Task|. #24

Closed dmikurube closed 7 years ago

dmikurube commented 7 years ago

For #19, ServiceResponseSchema is also to be generated through Task. It allows developers to use the library for multiple endpoints per Task/Config such as:

in:
    type: example_rest_service
    endpoint_type: users  # Accessing to api.example.com/users
in:
    type: some_rest_service
    endpoint_type: items  # Accessing to api.example.com/items which has a different JSON format
dmikurube commented 7 years ago

@muga Can you PTAL?

muga commented 7 years ago

LGTM 👍 (sorry for the delay)

dmikurube commented 7 years ago

Thanks, and no problems. I pushed the PR last week as WIP, and asked for reviewed just now. :)