search

embulk / embulk-base-restclient

Base class library for Embulk plugins to access RESTful services
https://www.embulk.org/
Apache License 2.0
6 stars 7 forks source link

Eliminate dynamic type checking in |JacksonServiceRecord|. #25

Closed dmikurube closed 7 years ago

dmikurube commented 7 years ago

Large version of fix for #23. Concerned that it needs developers to cast SchemaWriter in loadPage by themselves such as: https://github.com/dmikurube/embulk-base-restclient/pull/25/files#diff-625ea9164325bdd9b6969461114425feR136

    @SuppressWarnings("unchecked")
    SchemaWriter<JacksonValueLocator> jacksonSchemaWriter = (SchemaWriter<JacksonValueLocator>) schemaWriter;
dmikurube commented 7 years ago

Chose #26. Closing this PR.