search

embulk / embulk-base-restclient

Base class library for Embulk plugins to access RESTful services
https://www.embulk.org/
Apache License 2.0
6 stars 7 forks source link

Configure retries out of base classes. #44

Closed dmikurube closed 7 years ago

dmikurube commented 7 years ago

@muga Trying to remove config parameters which are unconditionally in the base Task class. This PR removes retry-related parameters.

We may encourage using common parameter names by preparing some default implementations with Java 8 interface w/ implementation.

dmikurube commented 7 years ago

@muga I didn't want to have these config parameters in RestClient*TaskBase because it enforces to have those parameters. It doesn't allow exceptions. It's not very good as a base library...

muga commented 7 years ago

@dmikurube thank you for explaining. I noticed that I was mis-understanding the design of RetryConfigurable and RestClientInputPluginDelegate.

We may encourage using common parameter names by preparing some default implementations with Java 8 interface w/ implementation.

And I agree with your description (sorry, I didn't see that). This should solve my concern. Thank you!

muga commented 7 years ago

so, LGTM 👍

dmikurube commented 7 years ago

Thanks!