search

embulk / embulk-base-restclient

Base class library for Embulk plugins to access RESTful services
https://www.embulk.org/
Apache License 2.0
6 stars 7 forks source link

Configure resuming out of base classes. #45

Closed dmikurube closed 7 years ago

dmikurube commented 7 years ago

In addition to #44, removing |incremental| as well.

dmikurube commented 7 years ago

(Its base branch is now configure-retry-out-of-base-classes. Change the base to master before merging.)

dmikurube commented 7 years ago

Ah, it may not be a very good change. Possibly better to improve ConfigDiffBuildable to replace the whole part below in resume? :

        if (this.resumeConfigurator.isResuming(task)) {
            return this.configDiffBuilder.buildConfigDiff(task, schema, taskCount, taskReports);
        } else {
            return Exec.newConfigDiff();
        }
dmikurube commented 7 years ago

This will be replaced with #45.